4444 Checks fix coverage upload.fixup 4 #5

bernhardkaindl · 2025-08-18T22:21:03Z

No description provided.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

bernhardkaindl

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

code-coverage

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 208-209 are not covered

python-libs/xcp/dmv.py

Line 209 in 6d224ae

return None

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 211 is not covered

python-libs/xcp/dmv.py

Line 211 in 6d224ae

def parse_dmv_info(self, fpath):

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 213-216 are not covered

python-libs/xcp/dmv.py

Line 216 in 6d224ae

json_formatted = {

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 229-230 are not covered

python-libs/xcp/dmv.py

Line 230 in 6d224ae

json_formatted["selected"] = self.variant_selected(

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 232 is not covered

python-libs/xcp/dmv.py

Line 232 in 6d224ae

json_formatted["active"] = get_active_variant(

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 234 is not covered

python-libs/xcp/dmv.py

Line 234 in 6d224ae

json_formatted["loaded modules"] = get_loaded_modules(

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 236 is not covered

python-libs/xcp/dmv.py

Line 236 in 6d224ae

return json_data, json_formatted

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 238-239 are not covered

python-libs/xcp/dmv.py

Line 239 in 6d224ae

dmv_list = {} # type: Dict[str, Any]

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 241-243 are not covered

python-libs/xcp/dmv.py

Line 243 in 6d224ae

self.dmv_list = {

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 248 is not covered

python-libs/xcp/dmv.py

Line 248 in 6d224ae

self.errors_list = {

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 254-257 are not covered

python-libs/xcp/dmv.py

Line 257 in 6d224ae

variants[k] = v

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 259 is not covered

python-libs/xcp/dmv.py

Line 259 in 6d224ae

json_formatted = {

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 266-272 are not covered

python-libs/xcp/dmv.py

Line 272 in 6d224ae

json_formatted["selected"] = selected

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 274-279 are not covered

python-libs/xcp/dmv.py

Line 279 in 6d224ae

json_formatted["active"] = active

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 281-282 are not covered

python-libs/xcp/dmv.py

Line 282 in 6d224ae

json_formatted["loaded modules"] = loaded

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 284 is not covered

python-libs/xcp/dmv.py

Line 284 in 6d224ae

self.dmv_list["drivers"][oldone["info"]] = json_formatted

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 286-290 are not covered

python-libs/xcp/dmv.py

Line 290 in 6d224ae

self.dmv_list["drivers"][json_data["name"]] = json_formatted

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 292 is not covered

python-libs/xcp/dmv.py

Line 292 in 6d224ae

    
           self.merge_jsondata(self.dmv_list["drivers"][json_data["name"]], json_formatted)

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 294-295 are not covered

python-libs/xcp/dmv.py

Line 295 in 6d224ae

lspci_out = subprocess.run(["lspci", '-nm'], stdout=subprocess.PIPE,

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 298-300 are not covered

python-libs/xcp/dmv.py

Line 300 in 6d224ae

continue

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 302-304 are not covered

python-libs/xcp/dmv.py

Line 304 in 6d224ae

continue

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 306-309 are not covered

python-libs/xcp/dmv.py

Line 309 in 6d224ae

self.process_dmv_data(json_data, json_formatted)

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 311-312 are not covered

python-libs/xcp/dmv.py

Line 312 in 6d224ae

lspci_out = subprocess.run(["lspci", '-nm'], stdout=subprocess.PIPE,

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 315-317 are not covered

python-libs/xcp/dmv.py

Line 317 in 6d224ae

self.process_dmv_data(json_data, json_formatted)

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 319-320 are not covered

python-libs/xcp/dmv.py

Line 320 in 6d224ae

return self.dmv_list

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 322-327 are not covered

python-libs/xcp/dmv.py

Line 327 in 6d224ae

for module_file in module_files:

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 329-334 are not covered

python-libs/xcp/dmv.py

Line 334 in 6d224ae

except FileNotFoundError:

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 336-341 are not covered

python-libs/xcp/dmv.py

Line 341 in 6d224ae

subprocess.run(

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 347-349 are not covered

python-libs/xcp/dmv.py

Line 349 in 6d224ae

uname_r = subprocess.run(["uname", '-r'], stdout=subprocess.PIPE, text=True,

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 351-357 are not covered

python-libs/xcp/dmv.py

Line 357 in 6d224ae

return False

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 359-360 are not covered

python-libs/xcp/dmv.py

Line 360 in 6d224ae

return self.errors_list

⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 362-364 are not covered

python-libs/xcp/dmv.py

Line 364 in 6d224ae

self.errors_list["message"] = os.strerror(errcode)

bernhardkaindl · 2025-08-18T22:22:02Z

xcp/dmv.py

+import re
+import struct
+import subprocess
+from typing import Any, Dict


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 24-31 are not covered

bernhardkaindl · 2025-08-18T22:22:02Z

xcp/dmv.py

+import subprocess
+from typing import Any, Dict
+
+from .compat import open_with_codec_handling


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 33 is not covered

bernhardkaindl · 2025-08-18T22:22:03Z

xcp/dmv.py

+from .compat import open_with_codec_handling
+
+dmv_proto_ver = 0.1
+err_proto_ver = 0.1


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 35-36 are not covered

bernhardkaindl · 2025-08-18T22:22:03Z

xcp/dmv.py

+dmv_proto_ver = 0.1
+err_proto_ver = 0.1
+
+def get_all_kabi_dirs():


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 38 is not covered

bernhardkaindl · 2025-08-18T22:22:03Z

xcp/dmv.py

+    dirs = []
+    for kabi_ver in os.listdir(modules_root):
+        updates_dir = os.path.join(modules_root, kabi_ver, "updates")
+        dmv_dir = os.path.join(modules_root, kabi_ver, "dmv")


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 40-44 are not covered

bernhardkaindl · 2025-08-18T22:22:04Z

xcp/dmv.py

+            info_file = os.path.join(module_dir, "info.json")
+            with open(info_file, "r", encoding="ascii") as json_file:
+                json_data = json.load(json_file)
+                variant = json_data["variant"]


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 176-184 are not covered

bernhardkaindl · 2025-08-18T22:22:04Z

xcp/dmv.py

+                variant = json_data["variant"]
+
+            return variant
+    return None


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 186-187 are not covered

bernhardkaindl · 2025-08-18T22:22:04Z

xcp/dmv.py

+    def __init__(self, updates_dir, lspci_out, runtime=False):
+        self.updates_dir = updates_dir
+        self.lspci_out = lspci_out
+        self.runtime = runtime


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 189-193 are not covered

bernhardkaindl · 2025-08-18T22:22:04Z

xcp/dmv.py

+        self.lspci_out = lspci_out
+        self.runtime = runtime
+
+    def variant_selected(self, modules):


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Line 195 is not covered

bernhardkaindl · 2025-08-18T22:22:04Z

xcp/dmv.py

+                info_file = os.path.join(module_dir, "info.json")
+                with open(info_file, "r", encoding="ascii") as json_file:
+                    json_data = json.load(json_file)
+                    variant = json_data["variant"]


⚠️ [code-coverage] _{reported by reviewdog 🐶}
Lines 198-206 are not covered

codecov · 2025-08-18T22:22:44Z

Codecov Report

❌ Patch coverage is 0% with 196 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
xcp/dmv.py	0.0%	196 Missing ⚠️

📢 Thoughts on this report? Let us know!

coveralls · 2025-08-18T22:23:17Z

Pull Request Test Coverage Report for Build 17054637565

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals
Change from base Build 17054641565:	0.0%
Covered Lines:	0
Relevant Lines:	0

💛 - Coveralls

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

move DMV common code to python-libs because RPU plugin calls these functions as well Signed-off-by: Chunjie Zhu <chunjie.zhu@cloud.com>

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

bernhardkaindl added 3 commits August 19, 2025 00:12

Checks: Fix coverage upload for unit tests on given Python version

0d6d139

Add .github/workflows/reviewdog-review.yml

e3adf0b

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

Let reviewdog report uncovered lines

eaecfc5

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

bernhardkaindl commented Aug 18, 2025

View reviewed changes

bernhardkaindl force-pushed the master branch from bc5aa0e to 21c6177 Compare August 18, 2025 22:29

bernhardkaindl force-pushed the Checks-Fix-coverage-upload.fixup-4 branch from 623aca2 to bbc199e Compare August 18, 2025 22:31

bernhardkaindl and others added 3 commits August 19, 2025 01:00

Add configuration for codecov.io

350c62c

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

CP-54481: support DMV RPU plugin

2e3f6ef

move DMV common code to python-libs because RPU plugin calls these functions as well Signed-off-by: Chunjie Zhu <chunjie.zhu@cloud.com>

xcp/dmv.py: Fixup CI errors

3be08cc

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

bernhardkaindl force-pushed the Checks-Fix-coverage-upload.fixup-4 branch from bbc199e to 3be08cc Compare August 18, 2025 23:01

bernhardkaindl force-pushed the master branch 11 times, most recently from 8a18101 to 2534106 Compare August 20, 2025 09:23

bernhardkaindl force-pushed the master branch from 52a4ea9 to e1ce4cc Compare August 27, 2025 12:53

4444 Checks fix coverage upload.fixup 4 #5

Are you sure you want to change the base?

4444 Checks fix coverage upload.fixup 4 #5

Uh oh!

Conversation

bernhardkaindl commented Aug 18, 2025

Uh oh!

bernhardkaindl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 17054637565

Details

💛 - Coveralls

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Aug 18, 2025 •

edited

Loading

coveralls commented Aug 18, 2025 •

edited

Loading