Listens to events (bullets.enable etc.) to deactivate and reactivate …#9
Open
fegemo wants to merge 4 commits intobespokejs:masterfrom
Open
Listens to events (bullets.enable etc.) to deactivate and reactivate …#9fegemo wants to merge 4 commits intobespokejs:masterfrom
fegemo wants to merge 4 commits intobespokejs:masterfrom
Conversation
…bulletting The motivation is to allow other plugins to conditionally disable the sub-steps created by bespoke-bullets. For example, a new bespoke-keys plugin might want to register a key to allow all bullets in a slide to be activated at once.
Member
|
This is looking pretty good! I noticed some |
|
I wonder if in general core should allow plugins to be enabled and disabled using events (or an API method). This might enable this level of control for all plugins (so long as plugins are developed to honor the request). |
Author
|
Hey @markdalgleish, my bad. I had forgot to implement those. I've just pushed a new commit. @mojavelinux, I agree it would be a good idea to have standard events for activating/deactivating plugins on bespoke.js itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bulletting
The motivation (#6) is to allow other plugins to conditionally disable the sub-steps created
by bespoke-bullets. For example, a new bespoke-keys plugin might want to register
a key to allow all bullets in a slide to be activated at once.