fix(service): migrate stale local protocol config#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix the MSI-owned service startup failure exposed by the 5.0.4 dogfood diagnostics. The service was reaching runtime preparation and then failing before SCM Running because the LocalSystem profile still had a Boundless config with protocol_version 4.1.0 while the current build expects 4.2.0.
This also adds rollback-surviving service lifetime diagnostics so the next package can distinguish manual stop/shutdown from serve errors or panics, and fixes package manifest version parsing when the packaged manifest has a UTF-8 BOM.
Changes
Validation
Notes
The paired-but-disconnected dogfood report is real, but this PR intentionally does not diagnose or change peer connectivity/tray flow. Current stopped-service/no-pipe state after the user stopped service/tray is not treated as evidence of the connection failure.
Elevated validation
This worker shell is not elevated (CODY-PC\iomancer, Administrator=false), so I did not run an SCM/MSI install-start smoke and did not force UAC.