[bug] inside createTask function in mandellib.js, generation is undefined#3
Open
sinwailam193 wants to merge 1 commit intobethrobson:masterfrom
Open
[bug] inside createTask function in mandellib.js, generation is undefined#3sinwailam193 wants to merge 1 commit intobethrobson:masterfrom
sinwailam193 wants to merge 1 commit intobethrobson:masterfrom
Conversation
…ined, so I passed in generation as the second parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Beth,
I learned a lot from your books, thank you for you're doing. As I came across in one of your chapters for the html5 book, the function createTask in mandellib.js contains an undefined variable, "generation". I simply added a second parameter into the function and in mandel.js I passed in 'generation' into the createTask for the web worker.