Warn when supportedFunctions contains an invalid regex#44
Open
Scottcjn wants to merge 3 commits into
Open
Conversation
- classDetector.ts: the regex-validation construction tripped no-new; add a targeted oxlint-disable since the constructor is intentionally invoked only to validate (unicorn/new-for-builtins still requires new). - vscode.ts mock: reorder window members so showTextDocument precedes showWarningMessage, satisfying perfectionist sort-objects. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportedFunctionsentries before building the combined detector patternReplaces #40 (branch renamed from
warn-invalid-supported-functions-regextofix/warn-invalid-supported-functions-regexper CI branch naming convention).Verification
npx vitest run test/core/classDetector.test.tsnpm run typecheck./node_modules/.bin/oxfmt --check src/core/classDetector.ts test/core/classDetector.test.ts test/__mocks__/vscode.tsgit diff --checkCloses #22