Refactor affects_lightmapped_meshes, introduce AmbientLightFlags#24509
Merged
alice-i-cecile merged 1 commit intoJun 9, 2026
Conversation
olukowski
approved these changes
Jun 2, 2026
olukowski
left a comment
Contributor
There was a problem hiding this comment.
Code looks good, and ambient light still works properly in the lighting example on my machine.
alice-i-cecile
approved these changes
Jun 7, 2026
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Yeah, this makes sense as a cleanup to me.
Contributor
Author
|
One heads up is that @Elabajaba mentioned that ambient light will be replaced, so this might be short-lived: https://discord.com/channels/691052431525675048/743663924229963868/1510811921782280282 |
Member
|
Yep, that's my hope too. |
Member
|
#18207 is the breadcrumb to the "remove ambient light" work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
affects_lightmapped_meshesmonochromaticambient lights as a follow up once Minimum Viable Monochromatic Lights #24428 landsSolution
AmbientLightFlagsbitflags structambient_light_affects_lightmapped_meshestoambient_light_flagsinGpuLightsstruct and matching WGSL-sideLightsstructAMBIENT_LIGHT_FLAGS_AFFECTS_LIGHTMAPPED_MESHES_BITconstantTesting
lightingandlightmapsexamples