Scrollbars autohide, select fix for reselecting current item closing popup - #25057
Merged
alice-i-cecile merged 2 commits intoJul 21, 2026
Merged
Conversation
alice-i-cecile
added
the
A-UI
alice-i-cecile
added
D-Straightforward
viridia
reviewed
Jul 19, 2026
| && let Ok((gutter, mut node)) = q_gutters.get_mut(child_of.parent()) | ||
| { | ||
| let padding = if overflows { gutter.0 } else { Val::ZERO }; | ||
| if node.padding.right != padding { |
Contributor
There was a problem hiding this comment.
I would suggest adding a clarifying note here, as this makes certain assumptions about the layout structure of the parent container - those assumptions are true in the case of feathers, but may not be true for non-feathers widgets generally.
For example, a headless scrollbar can be placed in a grid, a flexbox, or it can float on top as a separate layer. For a floating scrollbar, altering the padding of the parent wouldn't be the right move.
Also, the above code appears to handle both horizontal and vertical scrollbars, but I would think that adjusting the right padding would only work for vertical scrollbars.
Contributor
Author
There was a problem hiding this comment.
good spot, thanks. will add comment to make clear ScrollbarGutter is just for padding based ones and fix horizontal.
… also added comment on gutter to make clear its only for padding based scrollbars
Contributor
Author
|
both scrollbars 
reclaim horizontal (the bug) 
reclaim vertical (existing working) 
|
viridia
approved these changes
Jul 19, 2026
kfc35
approved these changes
Jul 19, 2026
kfc35
added
S-Ready-For-Final-Review
alice-i-cecile
added
the
M-Deliberate-Rendering-Change
viridia
pushed a commit
to viridia/bevy
that referenced
this pull request
Jul 21, 2026
…popup (bevyengine#25057) # Objective / Solution - Select control didn't close when reselecting the current item (mouse or keyboard), because that doesn't send an event from underlying widget (list). Added a new event ReselectListRow to bevy_ui_widget and send that, picked it up in select to close the select. - Scrollbar was hugging the right side of the popup too much so added some padding on it. - Scrollbar was visible whether content fitted or not. Added an auto_hide (default to true). ## Solution `cargo run --example feathers_gallery --features bevy_feathers` --- ## Showcase Select where all items fit: <img width="283" height="94" alt="image" src="https://github.com/user-attachments/assets/c37d827b-adc5-43f5-be32-d2420d65b668" /> Select where they don't: <img width="281" height="161" alt="image" src="https://github.com/user-attachments/assets/3b7a09e6-8755-46c1-88c7-5d51766000de" /> --------- Co-authored-by: John Payne <20407779+johngpayne@users.noreply.github.com>
zincdev0
pushed a commit
to zincdev0/bevy
that referenced
this pull request
Jul 22, 2026
…popup (bevyengine#25057) # Objective / Solution - Select control didn't close when reselecting the current item (mouse or keyboard), because that doesn't send an event from underlying widget (list). Added a new event ReselectListRow to bevy_ui_widget and send that, picked it up in select to close the select. - Scrollbar was hugging the right side of the popup too much so added some padding on it. - Scrollbar was visible whether content fitted or not. Added an auto_hide (default to true). ## Solution `cargo run --example feathers_gallery --features bevy_feathers` --- ## Showcase Select where all items fit: <img width="283" height="94" alt="image" src="https://github.com/user-attachments/assets/c37d827b-adc5-43f5-be32-d2420d65b668" /> Select where they don't: <img width="281" height="161" alt="image" src="https://github.com/user-attachments/assets/3b7a09e6-8755-46c1-88c7-5d51766000de" /> --------- Co-authored-by: John Payne <20407779+johngpayne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective / Solution
Solution
cargo run --example feathers_gallery --features bevy_feathersShowcase
Select where all items fit:
Select where they don't: