Add ensure! macro for BevyError#25061
Open
0xEgao wants to merge 1 commit into
Open
Conversation
alice-i-cecile
requested changes
Jul 18, 2026
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Needs a cross-link from bail! for discoverability :)
Contributor
Author
Done :) |
alice-i-cecile
approved these changes
Jul 19, 2026
Zeophlite
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Bevy provides
bevy_error!andbail!for error handling, but lacks a concise way to return an error when a condition is false.Fixes #24645.
Solution
ensure!macro that delegates tobail!when its condition is false.Severitysyntax.Testing
RUST_BACKTRACE=1 cargo test -p bevy_ecs --libcargo test -p bevy_ecs --doc ensurecargo clippy -p bevy_ecs --lib -- -D warningscargo fmt --all -- --checkShowcase