Fix invalid sparse buffer update pipeline queued on WebGL2 - #25245
Open
beicause wants to merge 1 commit into
Open
Fix invalid sparse buffer update pipeline queued on WebGL2#25245beicause wants to merge 1 commit into
beicause wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24944
#23434 queues the sparse buffer update pipeline with an invalid shader handle which causes the pipeline creation never to finish.
bevy/crates/bevy_render/src/render_resource/sparse_buffer_vec.rs
Line 296 in 25368b7
Solution
Let
specializetake a shader handle as key and don't specialize the pipeline if shader handle isNone.I also converted
FromWorldtoRenderStartup.Testing
Tested
loading_screenexample on web