Skip to content

Fix invalid sparse buffer update pipeline queued on WebGL2 - #25245

Open
beicause wants to merge 1 commit into
bevyengine:mainfrom
beicause:fix-sparse-buffer-vec-queues-invalid-shader
Open

Fix invalid sparse buffer update pipeline queued on WebGL2#25245
beicause wants to merge 1 commit into
bevyengine:mainfrom
beicause:fix-sparse-buffer-vec-queues-invalid-shader

Conversation

@beicause

@beicause beicause commented Aug 1, 2026

Copy link
Copy Markdown
Member

Objective

Fixes #24944

#23434 queues the sparse buffer update pipeline with an invalid shader handle which causes the pipeline creation never to finish.

shader: self.shader.clone().unwrap_or_default(),

Solution

Let specialize take a shader handle as key and don't specialize the pipeline if shader handle is None.
I also converted FromWorld to RenderStartup.

Testing

Tested loading_screen example on web

@kfc35 kfc35 added this to the 0.19.1 milestone Aug 1, 2026
@kfc35 kfc35 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 1, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Aug 1, 2026
@kfc35 kfc35 added the P-Regression Functionality that used to work but no longer does. Add a test for this! label Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

on 0.19.0 web firefox, demo loading screen, pipelines no longer become ready

2 participants