Add input id and event props #6
Conversation
| _createClass(EditableLabel, [{ | ||
| key: '_handleFocus', | ||
| value: function _handleFocus() { | ||
| value: function _handleFocus(event) { |
There was a problem hiding this comment.
Changes shouldn't happen to the bundle file. This is just the distribution bundle created by webpack. If you want to make changes, you need to change the src/main.jsx and rebundle.
README.md
Outdated
| } | ||
|
|
||
| _handleFocus(text) { | ||
| _handleFocus(text, id, event) { |
There was a problem hiding this comment.
I'm not sure that we should go with this approach of passing in the event and input ID through the focus handler. The event should already contain the input element, which will have the id, class, etc., on it already. If anything, I would suggest something like this would be sufficient:
handleFocus(text, e)
|
Any hope of merging here? |
|
I don't think the textarea option should be here. I think the idea in general of it is fine, but I'd prefer that to be a separate component instead of integrated into this one. This is meant to be a simple label/input. Also could you undo the changes to the package-lock.json? |
3 participants
No description provided.