Fix bug where add_operation manipulates the Object class#40
Open
PeterLanglois wants to merge 1 commit intobhgames:masterfrom
Open
Fix bug where add_operation manipulates the Object class#40PeterLanglois wants to merge 1 commit intobhgames:masterfrom
PeterLanglois wants to merge 1 commit intobhgames:masterfrom
Conversation
PeterLanglois
commented
Aug 23, 2024
| ['filter', 'some', 'all', 'none', 'in', 'map', 'reduce'].include?(operator.to_s) | ||
| end | ||
|
|
||
| def self.add_operation(operator, function) |
Author
There was a problem hiding this comment.
Didn't seem like this was doing anything, so I took it out.
Happy to add it back if desired.
luizgustavodarossi
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
add_operationis manipulating theObjectclass.It can add new methods to object as well as overwrite existing methods.
Solution
Replace
define_methodwithdefine_singleton_method.