Skip to content

PROMO-1368 update API to use coupon_overrides_other_promotions #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
YevenLourance wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

PROMO-1368 update API to use coupon_overrides_other_promotions #1213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 34 additions & 26 deletions reference/promotions.v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,15 +510,10 @@ components:
properties:
codes:
$ref: '#/components/schemas/CouponCode'
coupon_overrides_other_promotions:
$ref: '#/components/schemas/CouponOverridesOtherPromotions'
coupon_overrides_automatic_when_offering_higher_discounts:
type: boolean
example: false
default: false
description: |-
This field only has effect when `can_be_used_with_other_promotions` is `false`:
- When the property is set to `true`, the coupon will override the applied automatic promotions if it provides a greater discount.
- When the property is set to `fasle`, the coupon will not be applied if automatic promotions are already applied.
Trying to set the value of this field to `true` when `can_be_used_with_other_promotions` is `true` will yield a 422 error response.
$ref: '#/components/schemas/CouponOverridesAutomaticWhenOfferingHigherDiscounts'
coupon_type:
type: string
enum:
Expand All @@ -538,15 +533,10 @@ components:
properties:
codes:
$ref: '#/components/schemas/CouponCode'
coupon_overrides_other_promotions:
$ref: '#/components/schemas/CouponOverridesOtherPromotions'
coupon_overrides_automatic_when_offering_higher_discounts:
type: boolean
example: false
default: false
description: |-
This field only has effect when `can_be_used_with_other_promotions` is `false`:
- When the property is set to `true`, the coupon will override the applied automatic promotions if it provides a greater discount.
- When the property is set to `fasle`, the coupon will not be applied if automatic promotions are already applied.
Trying to set the value of this field when `can_be_used_with_other_promotions` is `true` will yield a 422 error response.
$ref: '#/components/schemas/CouponOverridesAutomaticWhenOfferingHigherDiscounts'
redemption_type:
type: string
description: The type of the promotion. Promotions applied automatically have a value of `AUTOMATIC` whereas promotions requiring a coupon have a value of `COUPON`.
Expand Down Expand Up @@ -580,16 +570,12 @@ components:
$ref: '#/components/schemas/CreatedFrom'
codes:
$ref: '#/components/schemas/CouponCode'
coupon_overrides_automatic_when_offering_higher_discounts:
type: boolean
example: false
default: false
description: |-
This field only has effect when the `redemption_type` is `COUPON` and `can_be_used_with_other_promotions` is `false`:
- When the property is set to `true`, the coupon will override the applied automatic promotions if it provides a greater discount.
- When the property is set to `fasle`, the coupon will not be applied if automatic promotions are already applied.

Trying to set the value of this field to `true` when the `redemption_type` is not `COUPON`, or when `can_be_used_with_other_promotions` is `true` will yield a 422 error response.
coupon_overrides_other_promotions:
$ref: '#/components/schemas/CouponOverridesOtherPromotions'

coupon_overrides_automatic_when_offering_higher_discounts:
$ref: '#/components/schemas/CouponOverridesAutomaticWhenOfferingHigherDiscounts'
redemption_type:
type: string
description: The type of the promotion. Promotions applied automatically have a value of `AUTOMATIC` whereas promotions requiring a coupon have a value of `COUPON`.
Expand Down Expand Up @@ -624,7 +610,7 @@ components:
- start_date
- status
- can_be_used_with_other_promotions
- coupon_overrides_automatic_when_offering_higher_discounts
- coupon_overrides_other_promotions
- coupon_type
PatchAutomaticPromotion:
title: Patch Automatic Promotion
Expand Down Expand Up @@ -1733,6 +1719,28 @@ components:
$ref: '#/components/schemas/CustomerSegmentIdLimitation'
required:
- not
CouponOverridesAutomaticWhenOfferingHigherDiscounts:
title: CouponOverridesAutomaticWhenOfferingHigherDiscounts
deprecated: true
type: boolean
example: false
default: false
description: |-
This property has been deprecated and `coupon_overrides_other_promotions` should be used instead.
This field only has effect when the `redemption_type` is `COUPON` and `can_be_used_with_other_promotions` is `false`:
- When the property is set to `true`, the coupon will override the applied automatic promotions if it provides a greater discount.
- When the property is set to `false`, the coupon will not be applied if automatic promotions are already applied.
Trying to set the value of this field to `true` when the `redemption_type` is not `COUPON`, or when `can_be_used_with_other_promotions` is `true` will yield a 422 error response.
CouponOverridesOtherPromotions:
title: CouponOverridesOtherPromotions
type: boolean
example: false
default: false
description: |-
- When this property is set to `true`, the coupon will always override all applied promotions, including both automatic and coupon promotions.
- When this property is set to `false`, the coupon will not be applied if any promotions are already applied.

N.B.: This field only has effect when `can_be_used_with_other_promotions` is `false`. Trying to set the value of this field when `can_be_used_with_other_promotions` is `true` will yield a 422 error response.
Channel:
title: Channel
type: object
Expand Down