Skip to content

Update intake extension to v0.1.5#47

Merged
bigsmartben merged 6 commits into
mainfrom
community/intake-0.1.5
Jul 3, 2026
Merged

Update intake extension to v0.1.5#47
bigsmartben merged 6 commits into
mainfrom
community/intake-0.1.5

Conversation

@bigsmartben

@bigsmartben bigsmartben commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

Updates the bundled extensions/intake snapshot to v0.1.5 and syncs the latest source repository changes from bigsmartben/spec-kit-intake.

This PR now includes the HTML mock readiness update from bigsmartben/spec-kit-intake#6:

  • Repositions previews/preview.html as the static HTML/CSS mock equivalent delivery artifact for visual-design intake.
  • Replaces preview mode vocabulary with build-html-mock / validate-html-mock.
  • Tightens HTML mock readiness validation for mock page surfaces, visualized component/state refs, visual spec refs, preview-local screenshot refs, anchors, IA matrix coverage, and adjacent visual spec package readiness.
  • Keeps preview.html out of source-of-truth refs and preserves coverage YAML as the validation/evidence layer.

Validation

  • C:\Users\24598\.cache\codex-runtimes\codex-primary-runtime\dependencies\python\python.exe -m pytest -q extensions\intake\tests\test_extension_contract.py
  • Result before regression test restore: 94 passed, 1 skipped
  • .\.venv\Scripts\python.exe -m pytest extensions\intake\tests\test_extension_contract.py -q
  • Result after regression test restore: 96 passed, 1 skipped

Community Catalog Submission

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Prepared with OpenAI Codex assistance: synchronized the released source snapshot, updated catalog metadata, addressed PR review feedback, restored regression coverage, ran validation, and updated this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 437389f014

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +234 to +235
if args.node_id:
root_ids = [args.node_id[index - 1] if len(args.node_id) == len(sources) else args.node_id[0]]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Validate supplied root ids against shard contents

When --node-id is provided, the parsed root ids are overwritten instead of being checked against the shard contents. In the recommended multi-root flow, a typo or swapped shard such as raw metadata rooted at 2 with --node-id 1 still exits PASS and writes captured_root_node_ids: ["1"], so downstream validators trust missing or incorrect Figma metadata as complete.

Useful? React with 👍 / 👎.

Comment on lines +114 to +121
allowed = [
'truncated="false"',
"truncated='false'",
'"truncated": false',
"'truncated': false",
"truncated: false",
]
return not any(marker in lower for marker in allowed)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Detect true truncation markers even when false markers exist

This treats a shard as untruncated whenever any allowed truncated=false marker appears anywhere in the text. If an XML capture has a non-truncated root but a nested node with truncated="true", the capture writes raw_metadata_complete: true and truncated: false, and the later raw-text check also misses it because truncated="false" is present.

Useful? React with 👍 / 👎.

Validate supplied Figma root ids against parsed shard roots instead of overwriting captured roots, and treat true truncation markers as blocking even when false markers are also present.

Assisted-by: OpenAI Codex (model: GPT-5, autonomous)

Copy link
Copy Markdown
Owner Author

Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5).

Addressed the review feedback in commit af6ce7a:

  • Validated supplied --node-id values against parsed shard root ids instead of overwriting captured roots.
  • Treated any true truncation marker as blocking even when false markers are also present.
  • Added regression coverage for mismatched supplied root ids and nested true truncation markers.

Validation:

  • .\\.venv\\Scripts\\python.exe -m pytest extensions\\intake\\tests\\test_extension_contract.py -q -k "figma_metadata_capture" -> 4 passed
  • .\\.venv\\Scripts\\python.exe -m pytest extensions\\intake\\tests\\test_extension_contract.py -q -> 80 passed, 1 skipped

All GitHub checks are passing on the updated PR head.

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af6ce7a452

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

allowed = [
'truncated="false"',
"truncated='false'",
'"truncated": false',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat compact false truncation markers as complete

When a supported .json metadata source uses compact JSON such as "truncated":false, this exact allow-list does not match, so looks_truncated() marks the shard as truncated, emits FIGMA_RAW_METADATA_TRUNCATED, and exits blocked even though the marker is explicitly false. Use a whitespace-tolerant false-marker check similar to the true-marker regex so valid minified JSON captures can pass.

Useful? React with 👍 / 👎.

Keep coverage for supplied root id mismatches and nested true truncation markers after the HTML mock readiness update.

Assisted-by: OpenAI Codex (model: GPT-5, autonomous)

Copy link
Copy Markdown
Owner Author

Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5).

Follow-up after commit c4337a60: commit 8d4f019 restores the regression coverage for the metadata capture fixes so the PR still protects both reviewed behaviors:

  • supplied --node-id values must match parsed shard root ids
  • nested true truncation markers must block capture even when a false marker is also present

Validation:

  • .\\.venv\\Scripts\\python.exe -m pytest extensions\\intake\\tests\\test_extension_contract.py -q -> 96 passed, 1 skipped

I did not resolve review conversations.

Refresh PR checks after restoring required community submission metadata in the PR body.

Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
Allow compact false truncation markers such as JSON truncated:false while preserving true-marker blocking.

Assisted-by: OpenAI Codex (model: GPT-5, autonomous)

Copy link
Copy Markdown
Owner Author

Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5).

Addressed the latest Codex review feedback in commit 483e2bb:

  • Replaced the exact false-marker allow-list with a whitespace-tolerant false-marker regex.
  • Preserved true-marker precedence so any true truncation marker still blocks capture.
  • Added regression coverage for compact JSON metadata with "truncated":false.

Validation:

  • .\\.venv\\Scripts\\python.exe -m pytest extensions\\intake\\tests\\test_extension_contract.py -q -k "figma_metadata_capture" -> 5 passed
  • .\\.venv\\Scripts\\python.exe -m pytest extensions\\intake\\tests\\test_extension_contract.py -q -> 97 passed, 1 skipped

I did not resolve review conversations.

@bigsmartben bigsmartben merged commit dafe1d1 into main Jul 3, 2026
14 checks passed
@bigsmartben bigsmartben deleted the community/intake-0.1.5 branch July 3, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant