Update intake extension to v0.1.5#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 437389f014
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if args.node_id: | ||
| root_ids = [args.node_id[index - 1] if len(args.node_id) == len(sources) else args.node_id[0]] |
There was a problem hiding this comment.
Validate supplied root ids against shard contents
When --node-id is provided, the parsed root ids are overwritten instead of being checked against the shard contents. In the recommended multi-root flow, a typo or swapped shard such as raw metadata rooted at 2 with --node-id 1 still exits PASS and writes captured_root_node_ids: ["1"], so downstream validators trust missing or incorrect Figma metadata as complete.
Useful? React with 👍 / 👎.
| allowed = [ | ||
| 'truncated="false"', | ||
| "truncated='false'", | ||
| '"truncated": false', | ||
| "'truncated': false", | ||
| "truncated: false", | ||
| ] | ||
| return not any(marker in lower for marker in allowed) |
There was a problem hiding this comment.
Detect true truncation markers even when false markers exist
This treats a shard as untruncated whenever any allowed truncated=false marker appears anywhere in the text. If an XML capture has a non-truncated root but a nested node with truncated="true", the capture writes raw_metadata_complete: true and truncated: false, and the later raw-text check also misses it because truncated="false" is present.
Useful? React with 👍 / 👎.
Validate supplied Figma root ids against parsed shard roots instead of overwriting captured roots, and treat true truncation markers as blocking even when false markers are also present. Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
|
Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5). Addressed the review feedback in commit
Validation:
All GitHub checks are passing on the updated PR head. @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af6ce7a452
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allowed = [ | ||
| 'truncated="false"', | ||
| "truncated='false'", | ||
| '"truncated": false', |
There was a problem hiding this comment.
Treat compact false truncation markers as complete
When a supported .json metadata source uses compact JSON such as "truncated":false, this exact allow-list does not match, so looks_truncated() marks the shard as truncated, emits FIGMA_RAW_METADATA_TRUNCATED, and exits blocked even though the marker is explicitly false. Use a whitespace-tolerant false-marker check similar to the true-marker regex so valid minified JSON captures can pass.
Useful? React with 👍 / 👎.
Keep coverage for supplied root id mismatches and nested true truncation markers after the HTML mock readiness update. Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
|
Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5). Follow-up after commit
Validation:
I did not resolve review conversations. |
Refresh PR checks after restoring required community submission metadata in the PR body. Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
Allow compact false truncation markers such as JSON truncated:false while preserving true-marker blocking. Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
|
Posted on behalf of @bigsmartben by OpenAI Codex (model: GPT-5). Addressed the latest Codex review feedback in commit
Validation:
I did not resolve review conversations. |
Summary
Updates the bundled
extensions/intakesnapshot to v0.1.5 and syncs the latest source repository changes frombigsmartben/spec-kit-intake.This PR now includes the HTML mock readiness update from
bigsmartben/spec-kit-intake#6:previews/preview.htmlas the static HTML/CSS mock equivalent delivery artifact for visual-design intake.build-html-mock/validate-html-mock.preview.htmlout of source-of-truth refs and preserves coverage YAML as the validation/evidence layer.Validation
C:\Users\24598\.cache\codex-runtimes\codex-primary-runtime\dependencies\python\python.exe -m pytest -q extensions\intake\tests\test_extension_contract.py94 passed, 1 skipped.\.venv\Scripts\python.exe -m pytest extensions\intake\tests\test_extension_contract.py -q96 passed, 1 skippedCommunity Catalog Submission
AI Disclosure
Prepared with OpenAI Codex assistance: synchronized the released source snapshot, updated catalog metadata, addressed PR review feedback, restored regression coverage, ran validation, and updated this PR.