-
Notifications
You must be signed in to change notification settings - Fork 123
CI: Modify publish.yml to support TestPyPI #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks like this is successfully pushing now, it will attempt to push to test.pypi for any push to bilby-dev/bilby. We should be more careful about people making branches on this fork to avoid overloading testpypi. If there is too much of a load on testpypi and we can't reduce the number of pushes, we can try setting up a different upload point. |
|
@ColmTalbot does this mean the PyPI uploads now happen when the tag is made rather than when the release is made? If so, we should update the docs. |
I guess technically yes, I can make the check |
Perhaps we should just remove the documentation for making tags from the terminal, that way we guide people towards always making them together? |
.github/workflows/publish.yml
Outdated
| release: | ||
| types: [published] | ||
|
|
||
| on: push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow needs to be triggered on release.
Updated the GitHub Actions workflow to trigger on push events and added a new job for publishing to TestPyPI.
Added conditions to restrict publishing to specific repository and handle local version stripping for TestPyPI.
53b333b to
f9bead8
Compare
Updated the GitHub Actions workflow to trigger on push events and added a new job for publishing to TestPyPI.
Closes #978