Typo fix... #6
Open
Typo fix... #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pretty sure xcode inferred something i didnt want and broke layout guides here
- this way we dont have to worry about dynamically computing top spaces anymore
…en with rounded corners
- this is a weird one... - the notifications that the system emits when the keyboard shows/hides/changes its frame are wrong in iOS 13 - this fix prevents this BS frames from causing problems by using the firstResponder status of the input text field - if the input text field is not active, that heightFromBottom is ZERO NO EXCEPTIONS
- i dont even want to TRY to figure this shit out; let users paste text normally and dont explode when they enter a memoji
- masking via UIImageView layer appears to have been broken, but we can still build the layer ourselves and use that
[20107] Guard explosions if we somehow receive a nil message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah, one needs the @ prefix for objective-c strings...