Fix bug in parallel pipelines caused by false reporting of fids #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, so the issue was there there existed fids with no input or output node in the graph, and so they were returned as input/output fids of the graph right? I think the solution should include figuring out who leaks these None to None fids. BTW, I am not sure I understand the missed conflicts that you are mentioning. We could discuss this out of the critical path however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fids with no input or output nodes were reported as output fids and input fids causing some conflicts in parallel pipelines (specifically in the distributed execution mode since we replace hdfs cat input fids with an input per block).
Note: this is not a complete solution. replacing HDFSCat with per block cat could cause some conflicts to go undetected. Example: (x | x | x | hdfs dfs -put -f - /1.txt; hdfs dfs -cat) where /1.txt existed before.