Skip to content

pandas 3 compatibility #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-spr merged 1 commit into from
Jan 26, 2026
Merged

pandas 3 compatibility #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mofapy2/build_model/save_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def saveMetaData(self):

ctype = self.samples_metadata[g][col].dtype

if ctype == "object":
if ctype in ("object", "str"):
try:
# Try to encode as ASCII strings
group_meta.create_dataset(
Expand Down Expand Up @@ -244,7 +244,7 @@ def saveMetaData(self):
].astype(orig_type)

ctype = self.features_metadata[m][col].dtype
ctype = "|S" if ctype == "object" else ctype.type
ctype = "|S" if ctype in ("object", "str") else ctype.type
view_meta.create_dataset(
col, data=np.array(self.features_metadata[m][col], dtype=ctype)
)
Expand Down