Feature/relationship matrix#95
Merged
Merged
Conversation
Introduces an optional `relationship` argument to `calculate_adjacency_score()` and `speed()`, letting neighbour pairs contribute a graded similarity from a user-supplied matrix instead of a strict identity match. `speed()` validates and pre-flattens the matrix once before the SA loop via the new exported `prep_relationship()` helper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Walks through a 16-treatment, 4-group blocked design and contrasts the default identity-only optimisation against `speed()` driven by a relationship matrix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
.Rbuildignore: exclude .claude/ and Rplots.pdf from package builds. .gitignore: exclude *.local.json. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
speed() forwards these explicitly from optim_params() while also splatting `...` to the objective function, so a direct `speed(..., bal_weight = 2)` triggered "matched by multiple actual arguments". `speed()` now stops with a message pointing the caller at `optimise_params = optim_params(...)`. Factor the dots guard and the pre-loop relationship prep into `.reject_optim_params_in_dots()` and `.prep_dots()` helpers. Vignette `genetic_relationship.qmd` gains a "Per-Pair Similarities" example with closely-related-pair highlighting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…eature/relationship-matrix
rogerssam
approved these changes
May 27, 2026
Contributor
rogerssam
left a comment
rogerssam
left a comment
There was a problem hiding this comment.
Looks good. Not sure if it needs a rebase after the recent merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rendered vignette: genetic_relationship.html