Conversation
👇 Click on the image for a new way to code review
Legend |
bislara
left a comment
bislara
left a comment
There was a problem hiding this comment.
Well done @ShivamPande18
Please check the review comments once and modify if required.
| VALID_CHARS = DIGITS+UPPER_CASE+LOWER_CASE+SYMBOLS | ||
|
|
||
| #Adding atleast 1 character of all types of valid characters | ||
| password_temp = random.choice(DIGITS)+ random.choice(UPPER_CASE)+ random.choice(LOWER_CASE)+ random.choice(SYMBOLS) |
There was a problem hiding this comment.
So everytime the pwd will have digit, upper_case,lower_case_symbols in the beginning in the same order. Can you modify this to have it in random sequence.
| #Adding atleast 1 character of all types of valid characters | ||
| password_temp = random.choice(DIGITS)+ random.choice(UPPER_CASE)+ random.choice(LOWER_CASE)+ random.choice(SYMBOLS) | ||
|
|
||
| if(length<8): |
There was a problem hiding this comment.
Since you have added only 4 chars in the top, the if condition will always be false right?
So, what is the use of that if condition?
|
Hi @bislara would you please merge my PR or tell me if you need any more modifications or clarifications? |
|
hey @ShivamPande18 , I have already reviewed the PR. Please check the comments and make the changes if required.
|
2 participants
Description
Python code for a simple CLI password generator in which you enter the length of the password you'd like to generate (Minimum 8) and it creates a strong random password containing symbols, capital letters, regular letters, and numbers.
Technologies and Languages
Python