Skip to content

Reject invalid Shamir share inputs#7

Open
KingParmenides wants to merge 1 commit into
bitaps-com:masterfrom
KingParmenides:fix-invalid-shamir-share-inputs
Open

Reject invalid Shamir share inputs#7
KingParmenides wants to merge 1 commit into
bitaps-com:masterfrom
KingParmenides:fix-invalid-shamir-share-inputs

Conversation

@KingParmenides
Copy link
Copy Markdown

Summary

  • Reject non-decimal threshold/total input before generating Shamir shares.
  • Parse validated inputs explicitly as base-10 integers.
  • Enforce a minimum threshold of 2 so invalid values cannot reach splitMnemonic.

This implements a direct web-tool validation fix for the invalid-threshold behavior reported in #6 and bitaps-com/jsbtc#48. Credit for the original report remains with that reporter; this PR is the implementation patch.

Verification

  • git diff --check

Bounty payout address for accepted implementation work: 39Q34P8A7g375yqEr8buvNJkUbRgKfbKQZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant