ledger: handle script path (use SignPsbtYieldedObject)#793
Open
Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Open
ledger: handle script path (use SignPsbtYieldedObject)#793Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Conversation
Member
Author
|
I manually tested this change with a LedgerS and a simple single signature wallet. |
Merged
Member
Author
|
cc @bigspider |
Sjors
force-pushed
the
2025/07/ledger-partial-sig
branch
from
75febff to
a4e74ce
Compare
Sjors
force-pushed
the
2025/07/ledger-partial-sig
branch
2 times, most recently
from
482dbd3 to
85cbdac
Compare
Member
Author
|
I forgot to change the returned objects in |
Sjors
force-pushed
the
2025/07/ledger-partial-sig
branch
from
85cbdac to
ee4f903
Compare
Member
Author
|
The remaining CI failures look spurious to me, just one of the trillion submodules in Coldcard fails to clone. |
Taken from LedgerHQ/app-bitcoin-new at 2.4.1
Sjors
force-pushed
the
2025/07/ledger-partial-sig
branch
from
ee4f903 to
e9be7c2
Compare
Member
Author
|
Rebased after #795 landed. |
Sjors
changed the title
Member
Author
|
Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent versions of the Ledger app changed the
sign_psbtto return aSignPsbtYieldedObjectinstead ofbytes, bytes.For our purposes this yielded object is just a
PartialSignature, but once we're ready to add MuSig2 support it can also yieldMusigPubNonce(round 1) andMusigPartialSignature(round 2).