Fix race condition in get_free_port (#802)#825
Open
therohityadav wants to merge 1 commit intobitcoin-core:masterfrom
Open
Fix race condition in get_free_port (#802)#825therohityadav wants to merge 1 commit intobitcoin-core:masterfrom
therohityadav wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #802
Problem
The
get_free_portfunction was previously binding to""(all interfaces). This caused a race condition where the OS would assign a port that appeared free on0.0.0.0but was actually unavailable or restricted whenbitcoindspecifically tried to bind to127.0.0.1milliseconds later.Solution
I updated
s.bind(("", 0))tos.bind(("127.0.0.1", 0)).This forces the OS to select a port specifically on the loopback interface ensuring it matches the interface
bitcoinduses in the tests.Verification
I verified locally that the function now returns a port explicitly bound to
127.0.0.1.