Add Cypherock X1 device support#828
Open
muzaffarbhat07 wants to merge 19 commits intobitcoin-core:masterfrom
Open
Add Cypherock X1 device support#828muzaffarbhat07 wants to merge 19 commits intobitcoin-core:masterfrom
muzaffarbhat07 wants to merge 19 commits intobitcoin-core:masterfrom
Conversation
…lient feat: Adds basic cypherock client
feat: Adds cypherock sdk to communicate with X1 firmware
Author
|
@achow101 Could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
1. SDK Integration
Added cypherock_sdk dependency to enable communication with the Cypherock X1 device.
Implemented device connection and communication flow using the SDK interface.
2. Hardware Wallet Client Implementation
Introduced CypherockClient(HardwareWalletClient) class.
Implemented core functionality required for:
Device initialization and communication
Address retrieval
Transaction signing (legacy transactions only, see limitations below)
Current Limitations
Transaction Signing
sign_tx(...) currently supports legacy transactions only.
Although Cypherock X1 supports all address types, signing non-legacy transactions is currently blocked due to incomplete PSBT data:
For non-legacy inputs, PSBTs contain only witness_utxo
Full previous transaction data is missing
This prevents proper signing for those address types
Multisig Support
Cypherock X1 does not yet support multisig transactions or multisig addresses.
Multisig support is currently in progress on the Cypherock side.
Missing / Follow-ups
Add unit tests for CypherockClient
Add simulator testing (if mandatory by CI standards)
Extend sign_tx(...) support once full previous transaction data is available in PSBT
Any other missing requirement