Open
Conversation
luisschwab
requested changes
Feb 12, 2026
87e12ff to
5f551b0
Compare
luisschwab
requested changes
Feb 13, 2026
5f551b0 to
edd6c75
Compare
edd6c75 to
3be5d5c
Compare
ValuedMammal
reviewed
Mar 1, 2026
Comment on lines
+3
to
+5
| A minimal, experimental Bitcoin Core RPC client designed specifically for the Bitcoin Dev Kit (BDK). Unlike generic RPC wrappers, | ||
| `bdk-bitcoind-client` focuses on high-performance data emission and strict type safety, with built-in support for multiple Bitcoin | ||
| Core versions (v28.0 through v30.0+). |
Collaborator
There was a problem hiding this comment.
Unlike generic RPC wrappers,
bdk-bitcoind-clientfocuses on high-performance data emission
This sounds vague. You could just say it's a client that retrieves blockchain data from bitcoind over JSON-RPC.
A minimal, experimental Bitcoin Core RPC client
"experimental", though I expect there will be some BDK users who'd eventually like to use it in production as well.
Collaborator
|
This looks great. In 699fafc - docs: Update README for the library For code blocks you should include the language to enable syntax highlighting. Note that for toml files comments are denoted with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Readme for the library.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing