Skip to content

Taking a look at not passing the wallet to the builder#149

Open
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
thunderbiscuit:feat/no-wallet
Open

Taking a look at not passing the wallet to the builder#149
thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
thunderbiscuit:feat/no-wallet

Conversation

@thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Feb 27, 2026

This is just for exploration purposes. I was trying to figure out if there is value in passing to the builder just what we need instead of the whole wallet object.

It certainly makes the call site more complex.

fn build_with_wallet(
    self,
    txout_index: KeychainTxOutIndex<KeychainKind>,
    chain_tip: CheckPoint,
    network: Network,
    scan_type: ScanType,
) -> Result<LightClient, BuilderError>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant