feat!: Change ConfigBuilder::timeout to accept Option<Duration>
#180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed hidden lifetime in `Batch::iter` - Use `io::Error::other` in place of `io::Error::new` when the error kind is `ErrorKind::Other`.
ValuedMammal
force-pushed
the
feat/config_builder_timeout_duration
branch
from
0556eb4 to
5dc4bb6
Compare
Closed
radiant-smith-lk20
added a commit
to radiant-smith-lk20/rust-electrum-client
that referenced
this pull request
Dec 15, 2025
…ilder::timeout` to accept `Option<Duration>`
5dc4bb6360f1ff3f4b848a9b755c0c30a2e7e01b ci: bump clippy to 1.90.0 (valued mammal)
e31cf4773bf7e3f269ebff49726f8979592a1f15 feat!: Change ConfigBuilder::timeout to accept Option<Duration> (valued mammal)
Pull request description:
Change `ConfigBuilder::timeout` to accept `Option<Duration>`. This makes the API more explicit and less error prone, as the caller no longer needs to assume the units of the given duration.
Also updated the code to run clippy check in CI using rust 1.90.0.
BREAKING:
The `timeout` method on `ConfigBuilder` is changed to accept a `timeout: Option<Duration>`. Previously it was `Option<u8>`.
fix #151
fix #175
Supersedes #179
ACKs for top commit:
oleonardolima:
ACK 5dc4bb6360f1ff3f4b848a9b755c0c30a2e7e01b
Tree-SHA512: cd6ca6fdd91dcf6f193327ca40f6d37ea8b1b548102f080d0b72a0df509f6455aa50ee43148e4746ca6b295a30a78cb7d786fb0e90c050448e96e122a5b8c92d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ConfigBuilder::timeoutto acceptOption<Duration>. This makes the API more explicit and less error prone, as the caller no longer needs to assume the units of the given duration.Also updated the code to run clippy check in CI using rust 1.90.0.
BREAKING:
The
timeoutmethod onConfigBuilderis changed to accept atimeout: Option<Duration>. Previously it wasOption<u8>.fix #151
fix #175
Supersedes #179