Change default number format from hex to number#4201
Open
kajoseph wants to merge 2 commits into
Open
Conversation
kajoseph
added
the
BWC
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default numberFormat query parameter used by bitcore-wallet-client API requests from 'hex' to 'number', and updates a wallet-client API test to match the new numeric return shape for EVM gas fee fields.
Changes:
- Introduces a
defaultNumberFormatconstant set to'number'and uses it as the fallback for several tx proposal-related API calls. - Updates
getStatus()to requestnumberFormat=numberforpendingTxps. - Adjusts an EVM tx proposal test to assert numeric
maxGasFee/priorityGasFeevalues rather than hex strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/bitcore-wallet-client/src/lib/api.ts | Switches default numberFormat used in status/txproposal endpoints from 'hex' to a shared 'number' default. |
| packages/bitcore-wallet-client/test/api.test.ts | Updates assertions to expect numeric gas fee fields returned under the new default format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1401
to
+1405
| const qs = []; | ||
| qs.push(`includeExtendedInfo=${opts.includeExtendedInfo ? '1' : '0'}`); | ||
| qs.push(`twoStep=${opts.twoStep ? '1' : '0'}`); | ||
| qs.push('serverMessageArray=1'); | ||
| qs.push('numberFormat=hex'); // Only applies to `pendingTxps` in response. TODO apply this to balances as well. | ||
| qs.push('numberFormat=' + defaultNumberFormat); // Only applies to `pendingTxps` in response. TODO apply this to balances as well. |
Comment on lines
1734
to
+1737
| const args = { | ||
| proposalSignature: Utils.signMessage(hash, this.credentials.requestPrivKey) | ||
| }; | ||
| const qs = `numberFormat=${opts.numberFormat || 'hex'}`; | ||
| const qs = `numberFormat=${opts.numberFormat || defaultNumberFormat}`; |
Comment on lines
1940
to
1943
| opts = opts || {}; | ||
| const { doNotVerify, forAirGapped, doNotEncryptPkr } = opts; | ||
| const qs = `numberFormat=${opts.numberFormat || 'hex'}`; | ||
| const qs = `numberFormat=${opts.numberFormat || defaultNumberFormat}`; | ||
|
|
leolambo
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current default number format is hex which needs some further refinement
Changelog
Testing Notes
Add any helpful notes for reviewers to test your code here.
Checklist