-
Notifications
You must be signed in to change notification settings - Fork 15
[AI-61] feat: Add opt-in Jira write tools to bitwarden-atlassian-tools #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ef0fb4
[AI-61] feat: Add opt-in Jira write tools to bitwarden-atlassian-tools
SaintPatrck 35e4c13
Align write-token scope docs with actual granted scopes
SaintPatrck eefdeb1
Address multi-agent code review findings on the write tools
SaintPatrck a0ddb48
Address PR review suggestions on the write tools
SaintPatrck f04b931
Drop prototype framing from the write tools registration comment
SaintPatrck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "name": "bitwarden-atlassian-tools", | ||
| "version": "2.4.0", | ||
| "description": "Read-only Atlassian access via MCP server with deep Jira issue research skill, JQL search, Confluence pages, CQL search, and attachments", | ||
| "version": "2.5.0", | ||
| "description": "Atlassian access via MCP server with deep Jira issue research skill, JQL search, Confluence pages, CQL search, attachments, and opt-in Jira write tools", | ||
| "author": { | ||
| "name": "Bitwarden" | ||
| }, | ||
| "keywords": ["atlassian", "jira", "confluence", "mcp", "read-only", "cql"] | ||
| "keywords": ["atlassian", "jira", "confluence", "mcp", "cql"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
.../bitwarden-atlassian-tools/mcp/bitwarden-atlassian-mcp-server/src/jira/auth-write.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { describe, it, expect, beforeEach, afterEach } from "vitest"; | ||
|
|
||
| import { loadJiraConfig, hasJiraWriteToken } from "./auth.js"; | ||
|
|
||
| const ENV_KEYS = [ | ||
| "ATLASSIAN_CLOUD_ID", | ||
| "ATLASSIAN_EMAIL", | ||
| "ATLASSIAN_JIRA_READ_ONLY_TOKEN", | ||
| "ATLASSIAN_JIRA_WRITE_TOKEN", | ||
| ] as const; | ||
|
|
||
| describe("Jira write-token access mode", () => { | ||
| const saved: Record<string, string | undefined> = {}; | ||
|
|
||
| beforeEach(() => { | ||
| for (const key of ENV_KEYS) { | ||
| saved[key] = process.env[key]; | ||
| delete process.env[key]; | ||
| } | ||
| process.env.ATLASSIAN_CLOUD_ID = "test-cloud-id"; | ||
| process.env.ATLASSIAN_EMAIL = "user@example.com"; | ||
| process.env.ATLASSIAN_JIRA_READ_ONLY_TOKEN = "read-token"; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| for (const key of ENV_KEYS) { | ||
| if (saved[key] === undefined) { | ||
| delete process.env[key]; | ||
| } else { | ||
| process.env[key] = saved[key]; | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| it("reports no write token on a read-only install", () => { | ||
| expect(hasJiraWriteToken()).toBe(false); | ||
| }); | ||
|
|
||
| it("still loads read config on a read-only install", () => { | ||
| expect(loadJiraConfig().apiToken).toBe("read-token"); | ||
| }); | ||
|
|
||
| it("defaults to the read token when no mode is given", () => { | ||
| process.env.ATLASSIAN_JIRA_WRITE_TOKEN = "write-token"; | ||
|
|
||
| expect(loadJiraConfig().apiToken).toBe("read-token"); | ||
| }); | ||
|
|
||
| it("uses the write token in write mode", () => { | ||
| process.env.ATLASSIAN_JIRA_WRITE_TOKEN = "write-token"; | ||
|
|
||
| expect(hasJiraWriteToken()).toBe(true); | ||
| expect(loadJiraConfig("write").apiToken).toBe("write-token"); | ||
| }); | ||
|
|
||
| it("throws naming the write variable when write mode has no token", () => { | ||
| expect(() => loadJiraConfig("write")).toThrow(/ATLASSIAN_JIRA_WRITE_TOKEN/); | ||
| }); | ||
|
|
||
| it("treats an unexpanded template placeholder as absent", () => { | ||
| process.env.ATLASSIAN_JIRA_WRITE_TOKEN = "${ATLASSIAN_JIRA_WRITE_TOKEN}"; | ||
|
|
||
| expect(hasJiraWriteToken()).toBe(false); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.