Skip to content

[PM-41894] Fix conflicting Renovate docker checks - #516

Merged
jprusik merged 2 commits into
mainfrom
pm-41894
Aug 13, 2026
Merged

[PM-41894] Fix conflicting Renovate docker checks#516
jprusik merged 2 commits into
mainfrom
pm-41894

Conversation

@jprusik

@jprusik jprusik commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-41894

📔 Objective

The default docker Renovate manager is resulting in multiple docker-compose dependency checks

Because this can result in circular version bumping, and because we want to favor hash pinning over tags which are not immutable, we need to drop the default docker manager config in favor of the custom one for this project.

📸 Screenshots

Screenshot 2026-08-12 at 1 44 29 PM

@jprusik jprusik self-assigned this Aug 12, 2026
@jprusik
jprusik marked this pull request as ready for review August 12, 2026 17:55
@jprusik
jprusik requested a review from a team as a code owner August 12, 2026 17:55
@jprusik
jprusik requested a review from dan-livefront August 12, 2026 17:55
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR narrows .github/renovate.json by dropping the built-in dockerfile and docker-compose managers in favor of the existing custom.regex manager, and migrates the deprecated fileMatch key to managerFilePatterns. No Dockerfile exists in the repository, so removing the dockerfile manager loses no coverage, and both image: entries in docker-compose.yml (digest plus # <version> comment) still satisfy the custom manager's matchStrings pattern, preserving digest-pinned update behavior. The managerFilePatterns value uses the documented /regex/ delimited form and resolves to the same path matching as the previous fileMatch glob-style regex. The packageRules entry was correctly reduced to custom.regex, and no other rule, workflow, or config file references the removed managers.

Code Review Details

No findings.

@jprusik jprusik added the ai-review-vnext Request a Claude code review using the vNext workflow label Aug 12, 2026
@jprusik
jprusik merged commit 4727eb5 into main Aug 13, 2026
21 of 22 checks passed
@jprusik
jprusik deleted the pm-41894 branch August 13, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants