Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 361 361
Lines 43069 43069
=======================================
Hits 35488 35488
Misses 7581 7581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hinton
left a comment
There was a problem hiding this comment.
You also have to build both since otherwise the link will use old type definitions.
coroiu
left a comment
There was a problem hiding this comment.
Just one comment, otherwise good 👍
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
|





📔 Objective
Update the linking section of the SDK
READMEto more clearly state the recommended local linking steps, by focusing on the desired client build instead of the code on the client that you're working in.Link to rendered doc for review: https://github.com/bitwarden/sdk-internal/blob/0ab21c57bb219ad96c00c86c975b8642742be093/README.md#linking
🚨 Breaking Changes