[PM-30584] Implement key-connector migration in SDK#809
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 82.40% 82.49% +0.08%
==========================================
Files 350 351 +1
Lines 41751 42053 +302
==========================================
+ Hits 34404 34690 +286
- Misses 7347 7363 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thomas-Avery
left a comment
There was a problem hiding this comment.
Nice work the structure of these are easy to follow. One concern I found to take a look at.
crates/bitwarden-user-crypto-management/src/key_connector_migration.rs
Outdated
Show resolved
Hide resolved
crates/bitwarden-user-crypto-management/src/key_connector_migration.rs
Outdated
Show resolved
Hide resolved
crates/bitwarden-user-crypto-management/src/key_connector_migration.rs
Outdated
Show resolved
Hide resolved
|
@Thomas-Avery I've change the PR a bit to also implement key-context based wrap/unwrap for key-connector which should make this a bit more readable on the business logic side. |
…n/sdk-internal into km/key-connector-management-api
|
Also, added better docs for what is happening here. |
|
Thomas-Avery
left a comment
There was a problem hiding this comment.
Nice the refactor is even better!
…ent key-connector migration in SDK (bitwarden/sdk-internal#809)




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30584
bitwarden/server#7136
#809
bitwarden/clients#19360
📔 Objective
We do not want to keep the same master-key that was used during password derivation, but use a separately sampled key - named "key-connector-key". This means that the conversion flow now requires:
A new request endpoint is used compared to the previous key-connector-migration endpoint. This new endpoint always requires the key-connector-key-wrapped-user-key in the request body.
This will unblock setting the master-key to state during unlock and login, which will improve unlock time, since we can remove double-kdf-derivation.
📸 Screenshots