Skip to content

feat: automatically provide org ID for SM#817

Merged
tangowithfoxtrot merged 2 commits intomainfrom
auto-retrieve-orgid-sm
Mar 23, 2026
Merged

feat: automatically provide org ID for SM#817
tangowithfoxtrot merged 2 commits intomainfrom
auto-retrieve-orgid-sm

Conversation

@tangowithfoxtrot
Copy link
Copy Markdown
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Mar 5, 2026

📔 Objective

Remove the requirement for SM SDK consumers to manually provide the Organization ID.

@tangowithfoxtrot tangowithfoxtrot requested review from a team as code owners March 5, 2026 19:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

Logo
Checkmarx One – Scan Summary & Details2e3b7743-42ee-4c81-8f26-252650e553f2

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: auto-retrieve-orgid-sm (f17c36e)
Completed: 2026-03-05 19:30:17 UTC
Total Time: 276s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 47.72727% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.76%. Comparing base (f8a75af) to head (f17c36e).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
...twarden_license/bitwarden-sm/src/secrets/create.rs 30.00% 7 Missing ⚠️
...warden_license/bitwarden-sm/src/projects/delete.rs 0.00% 2 Missing ⚠️
bitwarden_license/bitwarden-sm/src/projects/get.rs 0.00% 2 Missing ⚠️
...itwarden_license/bitwarden-sm/src/projects/list.rs 0.00% 2 Missing ⚠️
...twarden_license/bitwarden-sm/src/secrets/delete.rs 0.00% 2 Missing ⚠️
...den_license/bitwarden-sm/src/secrets/get_by_ids.rs 0.00% 2 Missing ⚠️
bitwarden_license/bitwarden-sm/src/secrets/list.rs 50.00% 2 Missing ⚠️
bitwarden_license/bitwarden-sm/src/secrets/sync.rs 0.00% 2 Missing ⚠️
bitwarden_license/bitwarden-sm/src/client.rs 80.00% 1 Missing ⚠️
...warden_license/bitwarden-sm/src/client_projects.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   81.77%   81.76%   -0.02%     
==========================================
  Files         344      344              
  Lines       41116    41135      +19     
==========================================
+ Hits        33623    33632       +9     
- Misses       7493     7503      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tangowithfoxtrot tangowithfoxtrot merged commit 65c3ae1 into main Mar 23, 2026
58 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the auto-retrieve-orgid-sm branch March 23, 2026 15:10
bw-ghapp Bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants