[PM-33255] Fix OSS runtime error: register IBusinessUnitConverter in DI#7167
[PM-33255] Fix OSS runtime error: register IBusinessUnitConverter in DI#7167boris324 wants to merge 2 commits intobitwarden:mainfrom
Conversation
Change hardcoded response_mode from "form_post" to "query" for external IdP OIDC configurations. Per OpenID Connect Discovery 1.0 spec, the default supported response modes when omitted are "query" and "fragment" - not "form_post". Using "form_post" breaks SSO login with strict IdPs that don't support it and actively reject it. The "query" mode is what Bitwarden already accepts on the callback, so this change aligns the request with actual behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When Bitwarden is compiled with the OSS flag, IBusinessUnitConverter was not registered in the dependency injection container, causing a runtime error when OrganizationBillingController was activated. This adds a NoopBusinessUnitConverter implementation that throws NotSupportedException (consistent with other OSS noop services) and registers it in the OSS service collection via AddOosServices(). Fixes bitwarden#6292 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
|
Hi there! Thank you for taking the time to making a contribution. We already have some internal tracking of solving this issue so we aren't going to accept this body of work. We deeply appreciate the time and energy you took to try and help us resolve this and we should have a fix in soon 👍 |
cturnbull-bitwarden
requested review from
cturnbull-bitwarden
and removed request for
kdenney
|
@Patrick-Pimentel-Bitwarden I think this might have just included a bad branch reset. As the work you are referring to is done with #7154. This should probably be rebased to remove the first commit and only include the billing related changes. @boris324 Could you please remove the first commit and push again. Please also look into signing the CLA, without your signature we unfortunately can't accept any of your contributions. |
5 participants
Summary
OrganizationBillingControllerfails at runtime becauseIBusinessUnitConverteris not registered in the DI containerNoopBusinessUnitConverterinsrc/Core/Billing/Providers/Services/NoopImplementations/that throwsNotSupportedExceptionfor all methods (consistent with other OSS noop services likeNoopProviderService)AddOosServices()inSharedWeb/Utilities/ServiceCollectionExtensions.cs, which is used by both the Api and Admin projects when compiled with#if OSSTest plan
OrganizationBillingControllercan be activated without DI resolution errors in OSS buildsBusinessUnitConverterimplementationNoopBusinessUnitConverterTeststo confirm all methods throwNotSupportedException🤖 Generated with Claude Code