Skip to content

[PM-30245] Remove locked and inactive notifications feature flags from server#7174

Open
trmartin4 wants to merge 1 commit intomainfrom
platform/remove-locked-and-inactive-notifications-flags
Open

[PM-30245] Remove locked and inactive notifications feature flags from server#7174
trmartin4 wants to merge 1 commit intomainfrom
platform/remove-locked-and-inactive-notifications-flags

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Mar 8, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30245

📔 Objective

Removes pm-25130-receive-push-notifications-for-inactive-users and pm-19388-push-notifications-when-locked flags from the server. These were removed from clients as described below, so they are OK to remove now:

Flag Removed in commit Clients first release without flag Last client release with flag Server can remove at
pm-25130-receive-push-notifications-for-inactive-users 146e2c0a12e (2025-12-29) 2026.1.0 (all platforms) 2025.12.1 2026.3.0 ✅
pm-19388-push-notifications-when-locked 146e2c0a12e (2025-12-29) 2026.1.0 (all platforms) 2025.12.1 2026.3.0 ✅

Both flags were removed together. The last client with either flag was 2025.12.1. Server 2026.3.0's compatibility window starts at 2026.1.x, so no supported client checks these flags anymore so they safe to remove now.

📸 Screenshots

@trmartin4 trmartin4 marked this pull request as ready for review March 8, 2026 02:54
@trmartin4 trmartin4 requested review from a team and djsmith85 March 8, 2026 02:55
@trmartin4 trmartin4 changed the title Remove feature flags [PM-30245] Remove locked and inactive notifications feature flags from server Mar 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Logo
Checkmarx One – Scan Summary & Details35952fed-4f8f-401f-b0b5-37fc9949e927

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.88%. Comparing base (8d9ace6) to head (3fab724).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7174   +/-   ##
=======================================
  Coverage   56.88%   56.88%           
=======================================
  Files        2028     2028           
  Lines       88826    88826           
  Branches     7918     7918           
=======================================
  Hits        50528    50528           
  Misses      36468    36468           
  Partials     1830     1830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flags from clients removed with bitwarden/clients#18122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants