Skip to content

Reorganize seeder presets into purpose-based folders and remove obsolete presets#7176

Merged
theMickster merged 2 commits intomainfrom
PM-31023/pr1-reorg-cleanup
Mar 10, 2026
Merged

Reorganize seeder presets into purpose-based folders and remove obsolete presets#7176
theMickster merged 2 commits intomainfrom
PM-31023/pr1-reorg-cleanup

Conversation

@theMickster
Copy link
Contributor

🎟️ Tracking

PM-31023 - Relational Density Modeling
PM-32777 - Baked-In Density Preset Profiles

📔 Objective

  • Reorganize presets into purpose-based folders
  • Deprecate wonka-teams-small and large-enterprise in favor of the production scale presets (those will come in follow-up PRs)

Why the re-organization or presets?

The seeder is still early-adoption — breaking preset names now costs nearly nothing, but doing it after teams build scripts around them has cost. Purpose-based folders (features/qa/scale/validation) make preset discovery self-documenting so engineers don't need to read a README to find the right one. Consolidating docs into Seeds/docs/ eliminates duplication across scattered READMEs and separates everyday usage from developer-only verification content.

@theMickster theMickster added the ai-review Request a Claude code review label Mar 9, 2026
@claude
Copy link
Contributor

claude bot commented Mar 9, 2026

Claude finished @theMickster's task in 2m 15s —— View job


Re-Review: Reorganize seeder presets into purpose-based folders

Summary

The fix commit (4aae641) correctly updates all 8 moved preset files to use "$schema": "../../../schemas/preset.schema.json", resolving the broken schema paths from the initial review.

All previous findings addressed:

Finding Status
Broken $schema relative paths in moved presets Fixed in 4aae641 -- verified all 8 files now resolve correctly to Seeds/schemas/preset.schema.json
Validation README deleted without replacement Acknowledged -- follow-up PR planned
util/SeederUtility/README.md stale preset name references Not in scope for this PR -- noted for follow-up

No new issues found. No security, performance, or production code concerns -- all changes remain within util/Seeder/ tooling.

Approved -- ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Logo
Checkmarx One – Scan Summary & Details8fade016-d0f3-4eb7-9224-6b3f65f8c844

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.88%. Comparing base (63ca7fa) to head (4aae641).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7176   +/-   ##
=======================================
  Coverage   56.88%   56.88%           
=======================================
  Files        2028     2028           
  Lines       88826    88830    +4     
  Branches     7918     7918           
=======================================
+ Hits        50528    50531    +3     
- Misses      36468    36469    +1     
  Partials     1830     1830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@nthompson-bitwarden nthompson-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theMickster theMickster merged commit 465cbf3 into main Mar 10, 2026
51 of 52 checks passed
@theMickster theMickster deleted the PM-31023/pr1-reorg-cleanup branch March 10, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants