Skip to content

Add the new shell workflows for Claude actions#172

Merged
theMickster merged 5 commits intomainfrom
arch/PM-27181/implement-review-code
Oct 23, 2025
Merged

Add the new shell workflows for Claude actions#172
theMickster merged 5 commits intomainfrom
arch/PM-27181/implement-review-code

Conversation

@theMickster
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26935

📔 Objective

Bring the working workflow shells that should be used by future Bitwarden repos into the template.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@theMickster theMickster requested a review from a team as a code owner October 21, 2025 16:09
@theMickster theMickster requested review from a team and pixman20 and removed request for a team October 21, 2025 16:09
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Logo
Checkmarx One – Scan Summary & Details539629fc-c8c4-4c85-9d15-f260ba95d648

Great job! No new security vulnerabilities introduced in this pull request

withinfocus
withinfocus previously approved these changes Oct 21, 2025
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction but will you also propose Markdown files for defaults? I'd like to get a .claude folder in here.

@theMickster
Copy link
Contributor Author

This is a step in the right direction but will you also propose Markdown files for defaults? I'd like to get a .claude folder in here.

I had a similar thought, and will append a few markdown items.
I will start with what seems to be our generic .claude/prompts/review-code.md but am also okay if folks prefer that to be excluded from the template. Just let me know.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is exactly what I was thinking. Few improvements requested.

@theMickster theMickster merged commit 1bd8243 into main Oct 23, 2025
16 checks passed
@theMickster theMickster deleted the arch/PM-27181/implement-review-code branch October 23, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants