Draft
Conversation
They both declare `uninstall` targets, but OpenXR will only add its uninstall target if one doesn't exist yet...
Untested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
AudioMeshobject, with dynamic transform (Add dynamic audio geometry support #866, lovr.audio.setGeometry with phonon is kinda slow #406)lovr.audio.setHRTFto enable a custom HRTF. Binaural spatialization will only work if an HRTF has been set, otherwise the spatializer will fall back to simple panning.t.audio.debugto get log messages from Steam Audio and miniaudio.TODO (maybe not all in this PR):
lovr.audio.commit, use triple buffered audio updates (Atomic Audio Functions #892)lovr.audio.captureto make it easier to get mic samples without using a sink