Disable read timeout for streaming#169
Merged
Merged
Conversation
The httpx.AsyncClient() in start_streaming() used the default 5s read timeout, causing ReadTimeout when sandbox processes go quiet for more than 5 seconds during log streaming. Setting timeout=None disables all timeouts for this long-lived streaming connection, matching the pattern already used elsewhere in the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_streaming()to preventReadTimeouterrors when sandbox processes go quiet during log streaming.Details
The
httpx.AsyncClient()at line 158 ofprocess.pywas using the default 5s read timeout. When a sandbox process doesn't produce stdout/stderr for more than 5 seconds, the streaming connection would time out with aReadTimeoutexception (Sentry issue).The fix adds
timeout=Noneto disable all timeouts on this long-lived streaming connection, matching the pattern already used at line 310 in the same file.Insight: https://app.mendral.com/insights/01KTY5CWH09GKGXCH91PCT6A34
Note
Created by Mendral. Tag @mendral-app with feedback or questions.