Links relative to the server root are also relative.#95
Open
JorgenEvens wants to merge 1 commit intobleupen:masterfrom
Open
Links relative to the server root are also relative.#95JorgenEvens wants to merge 1 commit intobleupen:masterfrom
JorgenEvens wants to merge 1 commit intobleupen:masterfrom
Conversation
Author
|
Maybe this needs a different fix, as I just discovered that links which do not have a leading Results in Would the inverse of https://github.com/bleupen/halacious/blob/master/lib/plugin.js#L632 do the job? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring links that are relative to the root of the webserver in combination with the
absolute=trueplugin option causes non-absolute links to be generated.I think the problem lies in the
isRelativePathcheck, which should also consider paths relative to the server root as relative.Example:
Will currently return the following, note that the
hrefforkeysandvaluesare not absolute.