Implement shrine check for XP shrine status#467
Draft
tricky-eli wants to merge 5 commits intoblizzhackers:restructurefrom
Draft
Implement shrine check for XP shrine status#467tricky-eli wants to merge 5 commits intoblizzhackers:restructurefrom
tricky-eli wants to merge 5 commits intoblizzhackers:restructurefrom
Conversation
Added shrine check functionality to monitor XP shrine status and restore Helper settings when the shrine expires. Tired of deciding between getting XP shrine or Killing waves and Baal ? Now you dont have to. This code will get shrines if enabled in charconfig, it will also fight if you failed to find a shrine or if the shrine expires or gets cursed off, if you have Helper enabled. No extra settings. Get back in the fight ! please review and make any changes as needed. when a shrine is picked up it disables Helper. i added the CheckShrine after each wave, at red portal, and then in the leech spot loop. if shrine status is removed it will restore Helper and pick up the fight. tested 500 runs. (but before the Hurt addition so i just guessed at that part)
fixed {} error
fixed formating
fixed formatting with VS
fixed spaced and tabs with VS attempt 2
tried again to fix formatting with VS
Collaborator
|
Thanks for the PR but im not sure if i get what it tries to do |
Contributor
Author
hi, its essentially a shrine status monitor, it only works if: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added shrine check functionality to monitor XP shrine status and restore Helper settings when the shrine expires.
Tired of deciding between getting XP shrine or Killing waves and Baal ? Now you dont have to. This code will get shrines if enabled in charconfig, it will also fight if you failed to find a shrine or if the shrine expires or gets cursed off, if you have Helper enabled. No extra settings. Get back in the fight !
please review and make any changes as needed.
when a shrine is picked up it disables Helper.
i added the CheckShrine after each wave, at red portal, and then in the leech spot loop.(and some extra places, maybe it doesnt need them all?) if shrine status is removed it will restore Helper and pick up the fight. tested 500 runs with Helper and Shrine. (but before the Hurt addition so i just guessed at that part)