feat(staged): compact new session dialog#785
Conversation
Relocate the repo/subpath RepoLabel from the dialog body to the modal header, placing it to the right of the [New <type>] mode dropdown. The mode switcher and repo label are now grouped in a .header-left flex container while the close button stays right-aligned; the repo pill is slimmed to match the dropdown height and truncates with an ellipsis when space is tight. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b59bce9e76
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {#if imageIds.length === 0} | ||
| <ImageAttachment | ||
| branchId={branch.id} | ||
| projectId={branch.projectId} | ||
| disabled={starting} | ||
| {imageIds} | ||
| {onImageIdsChange} | ||
| /> | ||
| {/if} |
There was a problem hiding this comment.
When the dialog starts with no images, this conditional mounts a different ImageAttachment than the one used after the first image is added. If a user selects multiple files in one picker action, ImageAttachment.handleFileSelect is still looping asynchronously after the first onImageIdsChange, but this zero-image instance gets unmounted and continues with its stale imageIds prop; subsequent uploads call onImageIdsChange([...imageIds, image.id]) from the stale empty array, so earlier selected images can be dropped. Keep a single uploader instance mounted across the empty/non-empty transition or make the callback append against current parent state.
Useful? React with 👍 / 👎.
Signed-off-by: Matt Toohey <contact@matttoohey.com>
1 participant
Summary