fix: repair main build after cross-PR merge skew#1020
Merged
Conversation
error_outcome_emission_tests::test_config() (added by #1010) was missing the turn_liveness_secs field that #1017 added to Config — #1017's CI ran before #1010 merged so this third initializer was overlooked. Also fix desktop-tauri clippy manual_is_multiple_of in legacy_storage.rs (from #1016), which the pre-push hook enforces locally but GitHub CI did not exercise for that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent clippy/compile errors broke main (87e45c6) and the local pre-push hook, blocking
just releasefor v0.3.19.Both are cross-PR merge skew: CI for each contributing PR ran before its partner merged, so neither caught the conflict. The
error_outcome_emission_tests::test_config()initializer was added by #1010 before #1017 introducedturn_liveness_secs: u64onConfig; #1017 updated the two sibling test configs but missed this one. Themanual_is_multiple_ofclippy lint inlegacy_storage.rscame from #1016 but wasn't exercised by GitHub CI for that PR — only by the local pre-push hook.turn_liveness_secs: 10toerror_outcome_emission_tests::test_config()incrates/buzz-acp/src/lib.rs(matches field order and the value used by the two sibling test configs)bytes.len() % 2 == 0withbytes.len().is_multiple_of(2)indesktop/src-tauri/src/commands/legacy_storage.rs:83