Skip to content

fix(release): locate signed NSIS installer as the Windows updater artifact #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpfleger96 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −11
Open

fix(release): locate signed NSIS installer as the Windows updater artifact #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,23 +664,30 @@ jobs:
exit 1
fi

# Rename with _alpha-unsigned marker
# Tauri 2.x with createUpdaterArtifacts: true (v2 updater) signs the
# NSIS installer in place: it emits <name>-setup.exe + <name>-setup.exe.sig
# and NO separate .nsis.zip (that was the deprecated v1Compatible format).
# The signed installer IS the updater artifact. Capture its .sig before
# the rename below so the manifest signature matches the uploaded exe.
SIG="${EXE}.sig"
if [[ ! -f "$SIG" ]]; then
echo "::error::NSIS installer signature not found: $SIG"
exit 1
fi

# Rename with _alpha-unsigned marker, keeping the .sig in lockstep so the
# rolling-release archive name and its detached signature stay consistent.
EXE_DIR=$(dirname "$EXE")
EXE_BASE=$(basename "$EXE" .exe)
MARKED_EXE="${EXE_DIR}/${EXE_BASE}_alpha-unsigned.exe"
MARKED_SIG="${MARKED_EXE}.sig"
mv "$EXE" "$MARKED_EXE"
mv "$SIG" "$MARKED_SIG"
echo "exe=$MARKED_EXE" >> "$GITHUB_OUTPUT"

# Find the updater .nsis.zip and .sig
ARCHIVE=$(find "$BUNDLE_DIR/nsis" -name '*.nsis.zip' ! -name '*.sig' -type f | head -1)
SIG="${ARCHIVE}.sig"
if [[ -z "$ARCHIVE" || ! -f "$SIG" ]]; then
echo "::error::NSIS updater archive or signature not found in $BUNDLE_DIR/nsis"
exit 1
fi
echo "archive=$ARCHIVE" >> "$GITHUB_OUTPUT"
echo "archive_name=$(basename "$ARCHIVE")" >> "$GITHUB_OUTPUT"
echo "sig=$SIG" >> "$GITHUB_OUTPUT"
echo "archive=$MARKED_EXE" >> "$GITHUB_OUTPUT"
echo "archive_name=$(basename "$MARKED_EXE")" >> "$GITHUB_OUTPUT"
echo "sig=$MARKED_SIG" >> "$GITHUB_OUTPUT"

- name: Read updater signature
id: read-sig
Expand Down