feat(desktop): restore archive identity UI in profile panel#961
Open
tellaho wants to merge 3 commits into
Open
feat(desktop): restore archive identity UI in profile panel#961tellaho wants to merge 3 commits into
tellaho wants to merge 3 commits into
Conversation
tellaho
force-pushed
the
tho/restore-archive-ui
branch
from
d9f873d to
9074860
Compare
Adds a Manage section below the quick-actions row with a full-width Archive / Unarchive button, plus the "Archived on this relay" flair under the displayName. Gated by the original three-path composition (self / relay admin or owner / NIP-OA owner of viewee) — the relay re-verifies authority on submit. Button label flips to "Archive agent" on bot profiles. Restores the 5-case e2e gate matrix that #917 dropped alongside the UI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…hive hook
Introduces useIdentityArchive(pubkey) in features/identity-archive/hooks.ts,
composing the three gate queries (relay membership, OA owner, archived
status) plus currentPubkey, owning both mutations and the toasted
archive/unarchive callbacks. Returns { canArchive, isArchived, isPending,
archive, unarchive }.
Both call sites (ProfileSummaryView and ProfileManageSection) consume the
hook directly, removing the six drilled props from UserProfilePanel and the
now-dead hook calls, handlers, and imports. Gate composition is preserved
verbatim: isSelf || isRelayAdminOrOwner || isOaOwnerOfViewee.
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Relocates the Archive/Unarchive Manage section so it renders after the metadata field group instead of above the memories/channels ingress, placing identity management at the bottom of the profile summary. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
force-pushed
the
tho/restore-archive-ui
branch
from
9074860 to
234b8c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the Archive / Unarchive entry point in
UserProfilePanelthat #917 stripped while landing the memory viewer. The NIP-IA backend stayed wired up — only the GUI was gone — so this is a pure UI restoration on top of the newUserProfilePanelSectionslayout.Per Dawn's review of the conversation thread, the old full-width button doesn't fit inside the new compact quick-actions row, so it gets its own
Managesection belowProfilePrimaryActions(option (b) from the design discussion).What's restored
user-profile-archived-flair).canArchive = isSelf || isRelayAdminOrOwner || isOaOwnerOfViewee. The relay re-verifies authority on submit; this is a UX guard.identity-archive.spec.ts) — self / admin / OA-owner / no-authority / archived-toggle. Case 5 is the only one exercising the unarchive path.Why option (b)
The old archive button was a full-width secondary
<Button>at the bottom of the panel. The new layout uses a compactProfilePrimaryActionsrow (Follow / Message / Edit). Putting Archive in that row would crowd a destructive-feeling action next to social actions; a dedicatedManagesection keeps the gating composition intact, signals it as a different class of action, and gives the unarchive flair room to live nearby.Test plan
tsc --noEmitcleanbiome checkclean on touched filespnpm test:e2e(theidentity-archive.spec.ts5-case matrix)