refactor(profiling): replace dd-trace-go profiler with pprof admin endpoint#300
Open
refactor(profiling): replace dd-trace-go profiler with pprof admin endpoint#300
Conversation
worstell
force-pushed
the
refactor/profiling-pprof-endpoint
branch
from
7b74701 to
c30c678
Compare
…dpoint Drops the in-process Datadog continuous profiler in favor of the standard net/http/pprof admin listener (the OSS-Go convention used by Kubernetes, Prometheus, etcd, CockroachDB, etc.). Profiles are pulled by an external scraper rather than pushed by the binary, leaving the choice of backend to operators. Removes the gopkg.in/DataDog/dd-trace-go.v1 dep entirely. To preserve the Go runtime metrics (runtime.go.*) that the dd-trace-go tracer's WithRuntimeMetrics() emitted, wires up go.opentelemetry.io/contrib/instrumentation/runtime on the existing OTel meter provider — the metrics flow through the same OTel pipeline as the rest of cachew's metrics. The pprof listener binds 0.0.0.0:6060; pod NetworkPolicy is the access-control boundary. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019e0410-4b1d-77fc-a775-b6febdd0108d
worstell
force-pushed
the
refactor/profiling-pprof-endpoint
branch
from
c30c678 to
a21491b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the in-process Datadog continuous profiler in favor of the standard
net/http/pprofadmin listener (the OSS-Go convention used by Kubernetes, Prometheus, etcd, CockroachDB, etc.). Profiles are pulled by an external scraper rather than pushed by the binary, leaving the choice of backend to operators.Removes the
gopkg.in/DataDog/dd-trace-go.v1dep entirely. To preserve the Go runtime metrics (runtime.go.*) that the dd-trace-go tracer'sWithRuntimeMetrics()emitted, wires upgo.opentelemetry.io/contrib/instrumentation/runtimeon the existing OTel meter provider — the metrics flow through the same OTel pipeline as the rest of cachew's metrics.Listener binds
0.0.0.0:6060; pod NetworkPolicy is the access-control boundary.