fix: publish Madrigal under Block npm scope#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
madrigalname to@block/madrigal.madrigal.Root Cause
The
Releaseworkflow reachednpm publish --access public --provenanceand failed with npmE403because the unscopedmadrigalpackage already exists on npm under another maintainer. Publishing under@block/madrigalavoids that name collision and matches the GitHub org/repo ownership.Verification
pnpm buildnpm pack --dry-run --ignore-scripts --access public --cache=/private/tmp/madrigal-npm-cache --loglevel=noticepnpm checkpnpm typecheckpnpm testbiome check .pnpm vitest run,pnpm biome check .,pnpm tsc --noEmitNote
The next
Releaseworkflow still requiresMADRIGAL_NPM_PUBLISH_TOKENto have publish permission for the@blocknpm scope.