Skip to content

Use blue indicator for sleeping miners#475

Merged
negarn merged 3 commits into
mainfrom
negar/sleeping-miners-blue-status-dot
Jun 17, 2026
Merged

Use blue indicator for sleeping miners#475
negarn merged 3 commits into
mainfrom
negar/sleeping-miners-blue-status-dot

Conversation

@negarn

@negarn negarn commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Show sleeping miners with the same blue status indicator used while waking
  • Preserve the grey indicator for offline miners

Test plan

  • Open the miners table with a sleeping miner and confirm its status dot is blue
  • Confirm offline miners still use the grey status dot
  • Confirm MinerStatus unit coverage remains green
image

@github-actions github-actions Bot added javascript Pull requests that update javascript code client labels Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (591590e960533ecb778b9d03032f5c9dd16f1fba...7cd4c3eaf6a8a49f2d74b94b7489357f418182ba, exact PR three-dot diff)
  • Model: gpt-5.5

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No findings.

Notes

The scoped diff only changes ProtoFleet miner status indicator priority, the shared sleeping status color, and related frontend tests. I did not find security, correctness, reliability, protobuf, backend, plugin, infrastructure, or pool-hijacking issues in the changed hunks.

Validation performed: reviewed .git/codex-review.diff, checked surrounding component/hook/type context, and ran git diff --check for the reviewed files.


Generated by Codex Security Review |
Triggered by: @negarn |
Review workflow run

@negarn negarn marked this pull request as ready for review June 17, 2026 14:45
@negarn negarn requested a review from a team as a code owner June 17, 2026 14:45
Copilot AI review requested due to automatic review settings June 17, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ProtoFleet miner list status indicator behavior so “sleeping” miners use the same blue dot styling as “waking”, while preserving a grey dot for offline miners.

Changes:

  • Adjust StatusCircle color mapping so sleeping uses the same intent-info (blue) class as pending/waking.
  • Update MinerStatus indicator selection logic to differentiate sleeping (blue) vs offline (grey).
  • Add a unit test covering the sleeping indicator selection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
client/src/shared/components/StatusCircle/StatusCircle.tsx Maps sleeping to the blue intent-info fill class.
client/src/protoFleet/features/fleetManagement/components/MinerList/MinerStatus.tsx Separates sleeping vs offline indicator statuses for the status dot.
client/src/protoFleet/features/fleetManagement/components/MinerList/MinerStatus.test.tsx Adds a test asserting the sleeping dot uses data-status="sleeping".

@negarn negarn merged commit 0e1feae into main Jun 17, 2026
79 checks passed
@negarn negarn deleted the negar/sleeping-miners-blue-status-dot branch June 17, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants