Add lighthouse to PQ interop #74
Conversation
ch4r10t33r
left a comment
ch4r10t33r
left a comment
There was a problem hiding this comment.
@hopinheimer can you please confirm that you binary working with the ssz secret key and public key files?
| privkey: "4fd22cf461fbeae4947a3fdaef8d533fc7fd1ef1ce4cd98e993210c18234df3f" | ||
| # verify /ip4/127.0.0.1/udp/9004/quic-v1/p2p/16Uiu2HAm7TYVs6qvDKnrovd9m4vvRikc4HPXm1WyLumKSe5fHxBv | ||
| enrFields: | ||
| ip: "46.224.135.169" |
There was a problem hiding this comment.
This IP is being used by zeam right now. Please backout the changes in this file. I'll handle it based on server availability.
There was a problem hiding this comment.
Deployment via ansible will require changes in other files as well.
- ansible/roles/lighthouse/tasks/main.yml
- ansible/roles/lighthouse/defaults/main.yml
- Modifications to generate-ansible-inventory.sh to include lighthouse nodes
- run-ansible.sh to include lighthouse nodes
@hopinheimer
There was a problem hiding this comment.
we should merge in the changes and get the IP from ethpandaops
There was a problem hiding this comment.
we already have one server that we can use @g11tech . But having another one does help. For ansible we need changes to other files as wel.
There was a problem hiding this comment.
so can you tell @hopinheimer what other changes we need for the ansible
There was a problem hiding this comment.
@ch4r10t33r answering your earlier question. yup the implementation consumes the key files but generates genesis in runtime for now over genesis.ssz/.json which I think should be fine for now. I think the node wouldn't have spun because of the above platform mismatch if you're running anything non-x86. alternatively if you want to just want to see if things are working now. you could pull my PR to lighthouse and run docker build . -t lighthouse:local and make subsequent changes in lighthouse-cmd.sh to pick the local image and run the local-devnet. but nonetheless I'll have the image updated tomorrow.
There was a problem hiding this comment.
Yes, I figured. On the key files, I wanted to highlight that although the hash-sig-cli generates both ssz and json files, the ssz ones are preferred. Thanks.
There was a problem hiding this comment.
yup, I noticed the legacy tag during generation of key. I have added it my tracker to switch over I think it should be okay for now.
There was a problem hiding this comment.
Also, feel free to retain 46.224.135.169 for lighthouse. I have moved zeam to another server. @hopinheimer
| @@ -0,0 +1,22 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Could you please also add a metrics flag to this node configuration? so it would make it much easier to collect metrics from the clients.
There was a problem hiding this comment.
Hi! we currently don't have metrics implemented yet as mentioned in the PR desc but it's a work in progress and will update here once it's ready.
4 participants
This PR adds lighthouse to PQ interop where the client compliant to the devnet-1. currently lighthouse lacks a few features as enumerated below