Skip to content

Conversation

@blocknotes
Copy link
Owner

@blocknotes blocknotes commented May 31, 2025

In this PR:

  • add query comments (using annotate);
  • setup Bullet gem for dev and test;
  • minor improvements to the dummy app.

ℹ️ bullet is disabled only in specific spec due to an offense that requires some investigation:

     # spec/integration/attachments_spec.rb:15
     Bullet::Notification::UnoptimizedQueryError:
       user: app
        
       AVOID eager loading detected
         ActiveStorage::Attachment => [:record]
         Remove from your query: .includes([:record])

@blocknotes blocknotes self-assigned this May 31, 2025
@blocknotes blocknotes force-pushed the dev/internal-improvements branch 3 times, most recently from 4f8924c to b6dc71c Compare May 31, 2025 12:46
@blocknotes blocknotes force-pushed the dev/internal-improvements branch from b6dc71c to cac243c Compare May 31, 2025 13:03
@blocknotes blocknotes force-pushed the dev/internal-improvements branch from cac243c to 8ebead9 Compare May 31, 2025 13:10
@blocknotes blocknotes marked this pull request as ready for review May 31, 2025 13:13
@blocknotes blocknotes merged commit 503b1a4 into main May 31, 2025
21 checks passed
@blocknotes blocknotes deleted the dev/internal-improvements branch May 31, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants