Skip to content

Handle a failing spec related to the Bullet offense #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blocknotes merged 2 commits into from
Jun 1, 2025
Merged

Handle a failing spec related to the Bullet offense #72

blocknotes merged 2 commits into from
Jun 1, 2025

Conversation

@blocknotes
Copy link
Owner

@blocknotes blocknotes commented Jun 1, 2025 •
edited
Loading

spec/integration/attachments_spec.rb:15

     Bullet::Notification::UnoptimizedQueryError:
       user: runner
        
       AVOID eager loading detected
         ActiveStorage::Attachment => [:record]
         Remove from your query: .includes([:record])

Explanation here: #69 (comment)

@blocknotes blocknotes self-assigned this Jun 1, 2025
@blocknotes blocknotes mentioned this pull request Jun 1, 2025
Closed
@blocknotes blocknotes force-pushed the bullet/address-query-offense branch from e903915 to 2e6b1d0 Compare June 1, 2025 10:05
@blocknotes blocknotes changed the title test: Enable failing spec related to the Bullet offense Handle a failing spec related to the Bullet offense Jun 1, 2025
@blocknotes blocknotes marked this pull request as ready for review June 1, 2025 10:09
@blocknotes blocknotes merged commit b61ae9f into main Jun 1, 2025
21 checks passed
@blocknotes blocknotes deleted the bullet/address-query-offense branch June 1, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@blocknotes blocknotes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blocknotes